Conversation
jmhain
requested review from
alexiscjohnson,
sigmacomputingluke and
sinanunan
sigmacomputingluke
approved these changes
Dec 12, 2023
Comment on lines
660
to
+661
| pub percent: bool, | ||
| pub quantity: Option<Expr>, | ||
| pub quantity: Option<TopQuantity>, |
There was a problem hiding this comment.
Nit: Would it make sense to encapsulate percent inside TopQuantity here given that fmt:Display only expects it when TopQuantity is set?
Collaborator
Author
There was a problem hiding this comment.
Maybe, though I usually try to keep the AST changes minimal since I plan to submit this upstream as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parser currently accepts Snowflake
SELECT TOPsyntax, but then it renders it using MSSQL syntax (where the expression is parenthesized), which causes the resultant queries to fail in Snowflake with syntax errors. This PR fixes the issue.