-
Notifications
You must be signed in to change notification settings - Fork 24
Feature: Blue Support #122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Teque5
wants to merge
15
commits into
main
Choose a base branch
from
feature/blue
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* drop scipy optional dependency and [apps] entirely * add documentation for converters * update converter entry points
* update documentation * allow converters to --archive (.sigmf) or create SigMF pairs (.sigmf-data & .sigmf-meta) * add tests
* fromfile() now autodetects SigMF, BLUE, & WAV formats automatically * Converters now support conversion to non-conforming dataset without writing datafiles back to disk * Add utils.get_magic_bytes() for autodetection purposes * split tests for converters into separate files * Validated implementation against lots of files beyond nonsigmf-examples repo * Updated converter documentation * Added slightly more to README * Drop support for float WAV files; tricky to support NCD * Fix bug in sigmffile._count_samples for NCD files * Fig bug in read_samples when using some NCD files with header & trailing bytes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to adding support for common BLUE/Platinum files this PR also fixes some unreported bugs related to reading captures when
header_bytesandtrailing_bytesexist.Currently blocked by PRs #116, #119, #120, #121, and https://github.com/sigmf/example_nonsigmf_recordings/pull/2.
I validated the bluefile i/o against https://github.com/sigmf/example_nonsigmf_recordings/ and many other
.cdiffiles I had around.TODO Before converting to full PR: