feat: add Hebrew language support with diacritics decomposition#10
Merged
feat: add Hebrew language support with diacritics decomposition#10
Conversation
2 tasks
AmitMY
force-pushed
the
feat/hebrew
branch
6 times, most recently
from
2930eb5 to
6e96c63
Compare
- Special-case MAX_MERGE_SIZE=2 in get_merges to avoid range() and tuple slicing, yielding pre-built pairs directly - Special-case size-2 merge to unpack and compare elements directly instead of creating tuple slices on every position - Use token directly instead of creating new Node in merge - Cache settings and len() as local variables 50 samples / 100 merges: 3.9s → 0.92s (4.3x faster) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Add FullyConnectedGraph vertex type for unordered merge candidates
- Hebrew decomposition: each grapheme cluster splits into base letter
+ fully connected graph of diacritics (nikkud, dagesh, cantillation)
- Single diacritics and bare letters collapse to plain Nodes
- All pairs of diacritics are valid merge candidates in any order
Example: בְּ (bet+sheva+dagesh) → NodesSequence([
utf8("ב"), FullyConnectedGraph([utf8("ְ"), utf8("ּ")])
])
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FullyConnectedGraphvertex type where every pair of nodes is a valid merge candidateNodesbytes(hebrew_grapheme_clusters(text)) == text.encode()Stacked on #9.
What improved
בְּרֵאשִׁ֖יתcan now be tokenized with linguistically meaningful structureExample
Test plan
ruff check .passes🤖 Generated with Claude Code