Closed
Conversation
2 tasks
AmitMY
force-pushed
the
test/reference-comparison
branch
16 times, most recently
from
51558ab to
f968db6
Compare
- Return self if merged subgraphs are identical to originals - Avoids creating new tuples and UnconnectedGraphs on no-op merges Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Standalone reference BPE and Boundless BPE implementations as ground truth (no graph abstraction, just byte sequences + counters) - Verify graph BPE, FastBPE, and Boundless BPE all produce identical merges to reference on same input - 5 tests across small, medium, and multi-implementation comparisons Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
AmitMY
force-pushed
the
test/reference-comparison
branch
from
f968db6 to
46be990
Compare
Contributor
Author
|
Redundant — BPE vs HuggingFace comparison is already covered in test_bpe.py. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #21.
What improved
Test plan
ruff check .passes🤖 Generated with Claude Code