Skip to content

Add dgs sentence split #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 29, 2022
Merged

Add dgs sentence split #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2d968b7
feat(dgs_corpus): add predefined sentence-level split
bricksdont Sep 29, 2022
0323729
feat(dgs_corpus): add sentence-level to known splits
bricksdont Sep 29, 2022
6c53d26
fix(dgs_corpus): unresolved variable name
bricksdont Sep 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
setup(
name="sign-language-datasets",
packages=packages,
version="0.1.2",
version="0.1.3",
description="TFDS Datasets for sign language",
author="Amit Moryossef",
author_email="amitmoryossef@gmail.com",
Expand Down
3 changes: 2 additions & 1 deletion sign_language_datasets/datasets/dgs_corpus/dgs_corpus.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@

_KNOWN_SPLITS = {
"3.0.0-uzh-document": path.join(path.dirname(path.realpath(__file__)), "splits", "split.3.0.0-uzh-document.json"),
"3.0.0-uzh-sentence": path.join(path.dirname(path.realpath(__file__)), "splits", "split.3.0.0-uzh-sentence.json")
}


Expand Down Expand Up @@ -377,7 +378,7 @@ def _generate_examples(self, data, split: List[str] | Dict[str, List[str]] = Non
else:
sentences = list(get_elan_sentences(datum["eaf"]))
for sentence in sentences:
if split is not None and sentence["id"] not in split[_id]:
if split is not None and sentence["id"] not in split[document_id]:
continue

if sentence["english"] is None:
Expand Down
Loading