dataset(signsuisse): add new dataset #25
Conversation
bricksdont
left a comment
bricksdont
left a comment
There was a problem hiding this comment.
Couple comments (I did not test the loader yet, will do later today)
| from ..warning import dataset_warning | ||
| from ...datasets import SignDatasetConfig | ||
|
|
||
| _DESCRIPTION = """ |
There was a problem hiding this comment.
minor: this text is not an ideal description; here is a suggestion:
Ein umfangreiches interaktives Lexikon der drei Gebärdensprachen der Schweiz (Deutschschweizerische Gebärdensprache DSGS, Langue des Signes Française LSF und Lingua Italiana dei Segni LIS). Herausgegeben vom Schweizerischen Gehörlosenbund (SGB-FSS).
|
I managed to download two thirds of all entries, and then ran into a 500 error: Found 15491 lexicon items.
Dl Completed...: 68%
10579/15491 [05:30<02:30, 32.72 url/s]
DownloadError: Failed to get url https://signsuisse.sgb-fss.ch/index.php?id=4&tx_issignsuisselexikon_anzeige%5Blanguid%5D=0&tx_issignsuisselexikon_anzeige%5Buid%5D=130937. HTTP code: 500.Does this perhaps mean that the API is limiting requests? |
|
you should restart the download. it will continue from the file it left off. seems like rate-limit to me, but I did not encounter such. |
|
ok, after restarting I can download everything now; and the dataset entries look correct to me. Can you bump the version? |
No description provided.