feat: --dry-run flag on publish CLI#32
Merged
ziv-lazarov-nagish merged 1 commit intonagishfrom Apr 26, 2026
Merged
Conversation
abb73dc to
3fa59af
Compare
3 tasks
This was referenced Apr 20, 2026
AmitMY
approved these changes
Apr 22, 2026
Contributor
AmitMY
left a comment
There was a problem hiding this comment.
Approved. Small, clean diff — the dry-run exit is in the right place in the pipeline. Follow-ups (non-blocking): guard against --dry-run --promote dispatching to the real promote path, and clarify in the help text that dry-run still performs HF reads (for version lookup and regression baseline).
9763fbf to
7944cde
Compare
3fa59af to
e8cbd3c
Compare
7944cde to
1329527
Compare
e8cbd3c to
d3b0da0
Compare
dd28274 to
4ca9439
Compare
Prints the generated model card (which already includes hyperparams, eval metrics, regression status, and version tag) and exits before any HF writes. No other side effects.
d3b0da0 to
27eadeb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on: #30 —
feat/publish-cliSummary
Fifth of a 5-PR stack (layers 1–4 split #22; this layer adds
--dry-runon top as a separate feature). Adds--dry-runto the publish CLI: when set, the pipeline runs through card generation as usual, writes the generated model card to./publish_dry_run.md(so it can be previewed in an IDE), prints a one-line summary oftag / revision / regressionstatus, and exits before any HF writes.Stack
5-PR stack — layers 1–4 split #22, layer 5 adds
--dry-run:feat/safetensors-runtime→nagish(PR feat: safetensors runtime loading + HF-aware resolver #28)feat/publish-utils-and-card→ feat: safetensors runtime loading + HF-aware resolver #28 (PR feat: publish utils — conversion, versioning, model card #29)feat/publish-hf-ops-and-eval→ feat: publish utils — conversion, versioning, model card #29 (PR feat: publish HF ops + evaluation helpers #31)feat/publish-cli→ feat: publish HF ops + evaluation helpers #31 (PR feat: publish CLI orchestrator #30)Test plan
uv run --extra dev --extra publish pytest sign_language_segmentation/tests/test_publish_cli.py— 5 passed (4 CLI orchestrator + 1 newtest_dry_run_writes_card_and_skips_hf)uv run --extra dev --extra publish pytest sign_language_segmentation/tests— 106 passeduv run --extra dev ruff check sign_language_segmentation/publish/— clean