Skip to content

feat: --dry-run flag on publish CLI#32

Merged
ziv-lazarov-nagish merged 1 commit intonagishfrom
feat/publish-dry-run
Apr 26, 2026
Merged

feat: --dry-run flag on publish CLI#32
ziv-lazarov-nagish merged 1 commit intonagishfrom
feat/publish-dry-run

Conversation

@ziv-lazarov-nagish
Copy link
Copy Markdown
Contributor

@ziv-lazarov-nagish ziv-lazarov-nagish commented Apr 20, 2026

Depends on: #30feat/publish-cli

Summary

Fifth of a 5-PR stack (layers 1–4 split #22; this layer adds --dry-run on top as a separate feature). Adds --dry-run to the publish CLI: when set, the pipeline runs through card generation as usual, writes the generated model card to ./publish_dry_run.md (so it can be previewed in an IDE), prints a one-line summary of tag / revision / regression status, and exits before any HF writes.

Stack

5-PR stack — layers 1–4 split #22, layer 5 adds --dry-run:

  1. feat/safetensors-runtimenagish (PR feat: safetensors runtime loading + HF-aware resolver #28)
  2. feat/publish-utils-and-cardfeat: safetensors runtime loading + HF-aware resolver #28 (PR feat: publish utils — conversion, versioning, model card #29)
  3. feat/publish-hf-ops-and-evalfeat: publish utils — conversion, versioning, model card #29 (PR feat: publish HF ops + evaluation helpers #31)
  4. feat/publish-clifeat: publish HF ops + evaluation helpers #31 (PR feat: publish CLI orchestrator #30)
  5. This PRfeat: publish CLI orchestrator #30

Test plan

  • uv run --extra dev --extra publish pytest sign_language_segmentation/tests/test_publish_cli.py — 5 passed (4 CLI orchestrator + 1 new test_dry_run_writes_card_and_skips_hf)
  • uv run --extra dev --extra publish pytest sign_language_segmentation/tests — 106 passed
  • uv run --extra dev ruff check sign_language_segmentation/publish/ — clean

Copy link
Copy Markdown
Contributor

@AmitMY AmitMY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Small, clean diff — the dry-run exit is in the right place in the pipeline. Follow-ups (non-blocking): guard against --dry-run --promote dispatching to the real promote path, and clarify in the help text that dry-run still performs HF reads (for version lookup and regression baseline).

Prints the generated model card (which already includes hyperparams,
eval metrics, regression status, and version tag) and exits before any
HF writes. No other side effects.
@ziv-lazarov-nagish ziv-lazarov-nagish changed the base branch from feat/publish-cli to main April 26, 2026 08:01
@ziv-lazarov-nagish ziv-lazarov-nagish changed the base branch from main to nagish April 26, 2026 08:02
@ziv-lazarov-nagish ziv-lazarov-nagish merged commit c374de0 into nagish Apr 26, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants