Fix sitemap generator writing to wrong path#250
Conversation
baseDir from path.resolve lacked a trailing separator, so the output path resolved to ".../translatedist/..." instead of ".../translate/dist/...".
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdated the build directory path construction in the sitemap generator to use cross-platform path separators via Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
baseDir from path.resolve lacked a trailing separator, so the output path resolved to ".../translatedist/..." instead of ".../translate/dist/...".
Note
Low Risk
Low risk: adjusts how the sitemap output directory is constructed to avoid missing path separators; no changes to sitemap contents or runtime logic beyond path building.
Overview
Fixes
tools/sitemap-generator.jsto buildbuildDirusingpath.sepsegments instead of string concatenation, ensuring the sitemap generator writes to.../translate/dist/...rather than an incorrect merged path.Written by Cursor Bugbot for commit 52670b6. This will update automatically on new commits. Configure here.
Summary by CodeRabbit