Override logs fixes #260
Merged
Override logs fixes #260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
foxish
commented
Oct 31, 2025
foxish
commented
| } else { | ||
| routingStr = sandboxName | ||
| } | ||
| routingStr = fmt.Sprintf("%-32s", routingStr) |
There was a problem hiding this comment.
the 32 chars looks odd on short names:
$ signadot local override --sandbox=test2 --workload=route --workload-port=8083 --with=localhost:18083
→ Applying override to test2
Waiting (up to --wait-timeout=3m0s) for sandbox to be ready...
✓ Sandbox status: Ready: All desired workloads are available.
✓ Local destination localhost:18083 will override sandbox responses as follows:
All HTTP/gRPC requests intended for sandbox test2, workload route, port 8083 will be sent to your local service at localhost:18083.
* If your local service (localhost:18083) responds with header `sd-override: true`:
-> Response from your local service (localhost:18083) is returned to the client.
* Otherwise:
-> Request is forwarded to the sandbox (test2).
Printing traffic logs below (press Ctrl+C to stop):
SERVED BY METHOD PATH -> STATUS
localhost:18083 POST /route.RoutesService/FindRoute -> 200
localhost:18083 POST /route.RoutesService/FindRoute -> 200
localhost:18083 POST /route.RoutesService/FindRoute -> 200
localhost:18083 POST /route.RoutesService/FindRoute -> 200
localhost:18083 POST /route.RoutesService/FindRoute -> 200
localhost:18083 POST /route.RoutesService/FindRoute -> 200
localhost:18083 POST /route.RoutesService/FindRoute -> 200
localhost:18083 POST /route.RoutesService/FindRoute -> 200
localhost:18083 POST /route.RoutesService/FindRoute -> 200
localhost:18083 POST /route.RoutesService/FindRoute -> 200
test2 POST /route.RoutesService/FindRoute -> 200
test2 POST /route.RoutesService/FindRoute -> 200
test2 POST /route.RoutesService/FindRoute -> 200
test2 POST /route.RoutesService/FindRoute -> 200
test2 POST /route.RoutesService/FindRoute -> 200
test2 POST /route.RoutesService/FindRoute -> 200Why don't we set a dynamic value based on the lenght of the sandbox and or local addr?
There was a problem hiding this comment.
I just went by the longest width needed for a sandbox - I'm a bit wary of the dynamic computation but I guess in this case it's quite safe.
There was a problem hiding this comment.
Will make this change and push
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.