Add --param-secret flag to plan run#323
Merged
Merged
Conversation
daniel-de-vera
force-pushed
the
plan-run-secrets
branch
from
f390c3f to
dda3949
Compare
Supports `signadot plan run --param-secret param-name=secret-name`, which maps plan param names to org secret names in the execution spec. The control plane decrypts secrets at dispatch time so decrypted values never appear in the plan_executions row or API responses. Rejects overlap between --param and --param-secret locally; other validations (unknown param, missing secret) are handled server-side. Bumps go-sdk to pick up PlanExecutionSpec.Secrets. Related: signadot/signadot#6904 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
daniel-de-vera
force-pushed
the
plan-run-secrets
branch
from
dda3949 to
e030519
Compare
daniel-de-vera
changed the title
Contributor
Author
|
@scott-cotton, I renamed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--param-secret param-name=secret-nametosignadot plan run, wiring a newSecrets map[string]stringintoPlanExecutionSpecso plan params can be bound to org secrets at execution time (without decrypted values ever touching the plan_executions row or API responses).--paramand--param-secretfor the same key locally; other validations (unknown param, missing secret) are handled server-side.PlanExecutionSpec.Secrets.Related: signadot/signadot#6904
Test plan
signadot plan run PLAN --param-secret api-key=my-secret→ execution created, response showssecrets: {api-key: my-secret}(name, not value)signadot plan run PLAN --param x=1 --param-secret x=my-secret→ fails locally withparam "x" appears in both --param and --param-secret; specify only onesignadot plan run PLAN --param-secret unknown=my-secret→ server rejects with 400 (key must match a declared plan param)signadot plan run PLAN --param-secret api-key=nonexistent→ server rejects with 400 (secret not found)context/api-key, same as a literal param🤖 Generated with Claude Code