Skip to content

Conversation

@jamesonwilliams
Copy link
Contributor

Contributor checklist

  • MacBook Pro M3 (test suite)
  • My contribution is fully baked and ready to be merged as is
  • I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit using the Fixes #1234 syntax

Description

Converting a few more unit tests to Kotlin:

app/src/test/java/org/thoughtcrime/securesms/recipients/RecipientExporterTest.java
app/src/test/java/org/thoughtcrime/securesms/recipients/RecipientUtilTest.java
app/src/test/java/org/thoughtcrime/securesms/util/DelimiterUtilTest.java
core-util/src/test/java/org/signal/core/util/concurrent/LatestPrioritizedSerialExecutorTest.java
libsignal-service/src/test/java/org/whispersystems/signalservice/api/services/DonationsServiceTest.java

Also migrated from Mockito to MocK where appropriate

Verified operation of modified tests:

./gradlew \
    :Signal-Android:testPlayProdDebugUnitTest \
    :core-util:testDebugUnitTest \
    :libsignal-service:test

@jamesonwilliams jamesonwilliams force-pushed the kotlinize-some-more-tests branch from 5e4e482 to 46ed43b Compare November 22, 2024 21:20
@jamesonwilliams jamesonwilliams marked this pull request as ready for review November 22, 2024 21:39
@greyson-signal
Copy link
Contributor

Thank you very much!

TheTechZone pushed a commit to Cerenia/Signal-Android that referenced this pull request Jan 6, 2025
AbandonedCart pushed a commit to SamSprung/Signal-Android that referenced this pull request Jan 31, 2025
Update libphonenumber to 8.13.50

Import correct InvalidKeyException in LinkDeviceRepository.

Resolves signalapp#13808

Use the correct link device flag.

Add support for the new Benin phone format.

Update translations and other static files.

Bump version to 7.26.1

Update backup integration tests.

Add new rules to log scrubber.

Potential fix for a backup validation error.

Force relays only if remote user is not a 'Signal Connection'.

Add "your media will be deleted today" mechanism based off last checkin time and media TTL.

Remove orphaned attachments when creating a new backup.

Add sgnl://ideal support to app deeplinks.

Add unit test for RegistrationUtil.

Use AEP for regv3 flows.

Fix creating message_fts table during database migration.

Fixes signalapp#13034
Fixes signalapp#13506

Rebuild FTS index in V239_MessageFullTextSearchEmojiSupport.

Rebuild FTS index in V242_MessageFullTextSearchEmojiSupportV2.

Resolves signalapp#13810

Fix multiple activity finish after donation.

Fix icon gradient.

Use ChatListener to get connection interrupted event from libsignal; clear connection state when received

Flesh out restore paths for regv3.

Update to libsignal 0.63.0

Add an internal sqlite playground.

Update linked devices strings.

Allow renaming of linked device.

Fix export bugs causing validation errors.

Update GV2 spinner transformer to for group updates in message extras.

Improve storage service diff logging.

Remove some unnecessary call tab requeries.

Verify group ids on peer-to-peer group changes.

Inject SignalWebSocket into IncomingMessageObserver.

Resolves signalapp#13820

Use calling service type for calls.

Kotlin-ize some more tests.

Resolves signalapp#13813

Fix empty username backupv2 export.

Fix lost voice notes on orientation change.

Allow group removal shortcut in chat folders.

Use EmojiTextView for chat folder names.

Center call link button.

Add validation error UI.

Split remote user check for group vs individual calls.

Ensure updateMessageRequestAcceptedState runs on main thread.

Convert more tests to kotlin.

Resolves signalapp#13825

Update most of the backup integration tests.

Add some more link+sync logs.

Use AEP when validating backup.

Fix incorrect ACI/PNI storage for revoked invites in group updates.

Fix denial dialog for call links.

Handle web socket closed unexpectedly errors more gracefully.

Inline the expireVersion capability.

Inline the deleteSync capability.

Fix calls silent ringer bug.

Fix GSE crash when attempting to send to non-GV2 groups.

Update to the latest backup tests.

Add call link strings.

Add sms provider failed specific messaging during registration.

Better progress messaging.

Update translations and other static files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants