Migrates a batch of tests from Mockito -> MockK #13832
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Contributor
|
Woohoo, thanks! |
greyson-signal
pushed a commit
that referenced
this pull request
Dec 12, 2024
4 tasks
TheTechZone
pushed a commit
to Cerenia/Signal-Android
that referenced
this pull request
Jan 6, 2025
AbandonedCart
pushed a commit
to SamSprung/Signal-Android
that referenced
this pull request
Jan 31, 2025
Fix issue with using registration recovery password. Update translations and other static files. Bump version to 7.27.1 Fix backup perf issue by doing cleanup inline. Reuse generated backup file if it's less than one hour old and enable resumable upload. Use LibSignalChatConnection for Authenticated Socket based on Remote Config Update to RingRTC v2.49.0 Fix bugs with notification schedules caused by 24xx end times. Add log section for backups. Fix backups crash when not signed in to play store. Fix hot loop when creating a subscription to remote backups. Allow restoration over cellular Add additional link+sync logs. Fix system PIP not closing on call end. Fix thread merge update archive NPE. Handle group call creation failure. Add link+sync error flows. Add a copy button to the SQLite Playground. Self-heal payment state transfer if onAdded fails to update as expected. Add InAppPaymentTableTest to verify functionality of update method. Display descriptive error using payment data instead of generic error. Update string translation comments. Properly escape CSV output in playground. Fix possible backup validation error. Update to libsignal 0.64.0 Add improved archive upload progress. Remove explicit indexed by statement from approximate exportable message count. Fix post-transfer emoji search. Improved progress indicator for backup file upload. Convert more tests to kotlin. Resolves signalapp#13829 Add thread delete progress logs. Add notification profile and chat folder backupv2 proto support. Update the backup playground to be more friendly. Fix dangling quote authors. Fix export issue with bad edit messages from during development. Fix bad one-time-payment receipt creation for cancelled iDEAL. Update restore banners with progress indicators and redirection. Close selection bar when nothing is selected. Limit wallpaper uploading to media tier. Rotate quick restore QR code and web socket. Add additional error handling in regv3 flows. Add learn more urls for regv3 flows. Update story strings and button. Remove some badly-formatted e164's. Convert a batch of tests from mockito -> mockk. Resolves signalapp#13832 Migrate all remaining mockito tests to mockk. Resolves signalapp#13835 Fix instrumentation tests. Resolves signalapp#13836 Rotate link+sync flag. Inline some paypal remote configs. Fix duplicate contacts during story selection. Fix delete options in note to self. Update translations and other static files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor checklist
Fixes #1234syntaxDescription
Continuing to work towards removing Mockito.
This PR updates a batch of tests, migrating off of Mockito and towards MockK. I just did a grep for
import.*mockitoand grabbed a handful to update:app/src/test/java/org/thoughtcrime/securesms/sms/UploadDependencyGraphTest.ktapp/src/test/java/org/thoughtcrime/securesms/stories/StoriesTest.ktapp/src/test/java/org/thoughtcrime/securesms/stories/StoryFirstTimeNavigationViewTest.ktapp/src/test/java/org/thoughtcrime/securesms/stories/dialogs/StoryContextMenuTest.ktapp/src/test/java/org/thoughtcrime/securesms/stories/viewer/StoryViewerViewModelTest.ktapp/src/test/java/org/thoughtcrime/securesms/stories/viewer/page/StoryViewerPageViewModelTest.ktapp/src/test/java/org/thoughtcrime/securesms/util/BackupUtilTest.ktapp/src/test/java/org/thoughtcrime/securesms/video/exo/ExoPlayerPoolTest.ktAfter this, there are 10 more tests using Mockito. I'll put up a separate PR to migrate those ones.
Testing
This still passes:
./gradlew qa