increase maximum description lenght in UI#14165
Open
isopod-a wants to merge 1 commit intosignalapp:mainfrom
Open
increase maximum description lenght in UI#14165isopod-a wants to merge 1 commit intosignalapp:mainfrom
isopod-a wants to merge 1 commit intosignalapp:mainfrom
Conversation
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Author
|
Please do not close this pr, since there are people who really need this increase in order to use Signal more fluently. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Is there a Problem with the PR? |
In the UI input, the number of glyphs is currently limited to 480 (with 8k max bytes). For larger groups with guidelines, more space is needed. This patch increases the number of glyphs and bytes by a factor of eight to 3840 and 65536. Signal community feature request: https://community.signalusers.org/t/expand-the-group-chat-description-or-pin-posts/65179
f76dbb5 to
f389fd4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First time contributor checklist
Contributor checklist
Fixes #1234syntaxDescription
In the UI input, the number of glyphs is currently limited to 480 (with 8k max bytes). For larger groups with guidelines, more space is needed.
This patch increases the number of glyphs and bytes by a factor of eight to 3840 and 65536.
Signal community feature request: https://community.signalusers.org/t/expand-the-group-chat-description-or-pin-posts/65179
On the test device a group description of new maximum length could be set and it could be viewed by other devices running the official release.
Equivalent implementation for iOS at isopod-a/Signal-iOS@6232ee7
and for Desktop client at isopod-a/Signal-Desktop@bdf40f4