chore(docs): improve docs examples with SSR considerations#175
Merged
vs-borodin merged 2 commits intomainfrom May 2, 2026
Merged
chore(docs): improve docs examples with SSR considerations#175vs-borodin merged 2 commits intomainfrom
vs-borodin merged 2 commits intomainfrom
Conversation
…necessary comments
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request cleans up documentation by removing redundant comments and updates Angular component examples to use the DOCUMENT token and inject function for accessing global objects like window and document. A feedback point was raised regarding TypeScript narrowing in the ScrollTracker example, suggesting the use of a local variable to safely access the narrowed window object within a closure to avoid potential type errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.