TUNE Request can optionally set DVB-C symbolrate#78
Open
rga-medix wants to merge 1 commit intosignalwareltd:masterfrom
Open
TUNE Request can optionally set DVB-C symbolrate#78rga-medix wants to merge 1 commit intosignalwareltd:masterfrom
rga-medix wants to merge 1 commit intosignalwareltd:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the Mygica PT-362 I was able to test DVB-C successfully. So Si2168 seems to work fine with it.
Setting the DVB-C symbolrate is mandatory though. Previously "0" was hardcoded. Setting it to a reasonable default value such as 6900 kSym/s, which is the Standard in Europe worked.
I have expanded the TUNE request to allow dynamically setting the symbolrate if needed. It is all optioanal and also an additional parameter. Therefore it should not break any older apps that access the driver.
Closes #56