Skip to content

Rewrite: Webhooks#440

Merged
Manny-r31 merged 4 commits into
mainfrom
Manny/Webhooks-rewrite
Jun 29, 2026
Merged

Rewrite: Webhooks#440
Manny-r31 merged 4 commits into
mainfrom
Manny/Webhooks-rewrite

Conversation

@Manny-r31

Copy link
Copy Markdown
Collaborator

Rewrite of Webhooks pages to match how to correctly setup webhooks in current dashboard

Description

Rewrite of Webhooks pages to match how to correctly setup webhooks in current dashboard. Old webhooks page referenced legacy dashboard and was not formatted properly. Also had a lot of redundancy.

Type of Change

  • Documentation update

Related Issues

#370

Testing

  • Tested manually

Checklist

  • I have read the CONTRIBUTING guidelines
  • My code follows the project's style guidelines
  • I have updated documentation (if applicable)
  • All existing tests pass

@github-actions

github-actions Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

hey-august
hey-august previously approved these changes Jun 29, 2026

@hey-august hey-august left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hey-august

Copy link
Copy Markdown
Collaborator

Voice-calls row may under-specify what's required to receive these states.

The status-callback table lists call_state_url on connect as the thing to set, with "States you'll receive: created, ringing, answered, ended." But delivering those states actually takes a second parameter, call_state_events, which selects which states are sent — and per the spec it defaults to ['ended']:

// specs/swml/calling/Methods/connect/main.tsp:171
call_state_events?: CallStatus[] = #[CallStatus.ended];

So a reader who sets only call_state_url will receive just ended, not the four states the table promises. Messages and Recordings don't have this opt-in array, so those rows are correct as written — voice is the only one with the two-parameter shape, which is what makes it easy to miss.

Suggest a short note under the table rather than widening the column:

<Note>
For voice calls, `call_state_events` defaults to `['ended']` — set it explicitly to also receive `created`, `ringing`, and `answered`.
</Note>

hey-august
hey-august previously approved these changes Jun 29, 2026

@hey-august hey-august left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LEBNTM! (looks even better now to me)

@Manny-r31 Manny-r31 merged commit 6932df6 into main Jun 29, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants