The generator now output a node package, and the generated code can have depedencies.#1
Merged
olivier-spinelli merged 2 commits intodevelopfrom Sep 28, 2022
Merged
Conversation
added 2 commits
August 2, 2022 16:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a LibraryImport readonly struct type.
"EnsureImportFromLibrary" now take it in parameter, instead of a string for the library name.
The
ITSFileImportSectionnow exposes aIReadOnlyDictionary<string, LibraryImport> LibraryImports { get; }. You can get the library imports from aTypeScriptFilebeause it expose aITSFileImportSection. The rootTypeScriptFolderwill generate apackage.json`, with the dependencies listed in the files.If there is multiple imports of the same library, a simple conflict resolution is made:
If the version mismatch, that's an error.
The
dependencyKindget upgraded, in the following orderdevDependencies=>dependencies=>peerDependencies.The package name is fixed to
@signature/generated.If a package
libraryis produced, and depend on the generated package with the nameabc, the dependent must have the generated code with the nameabc, if it generatedefinstaed, the node resolution will fail.This feature is package-manager neutral, it follow the node package.json format, it's up to the package manager that depends on the package to do the job.