Skip to content

Conversation

@divagant-martian
Copy link
Contributor

Issue Addressed

Fixes head syncing

Proposed Changes

  • Get back to statusing peers after removing chain segments and making the peer manager deal with status according to the Sync status, preventing an old known deadlock
  • Also a bug where a chain would get removed if the optimistic batch succeeds being empty

Additional Info

Tested on Medalla and looking good

Copy link
Member

@AgeManning AgeManning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@AgeManning
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Nov 1, 2020
## Issue Addressed

Fixes head syncing

## Proposed Changes

- Get back to statusing peers after removing chain segments and making the peer manager deal with status according to the Sync status, preventing an old known deadlock
- Also a bug where a chain would get removed if the optimistic batch succeeds being empty

## Additional Info

Tested on Medalla and looking good
@bors
Copy link

bors bot commented Nov 2, 2020

@bors bors bot changed the title Tweak head syncing [Merged by Bors] - Tweak head syncing Nov 2, 2020
@bors bors bot closed this Nov 2, 2020
@divagant-martian divagant-martian deleted the tweak-head-syncing branch January 4, 2021 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants