Skip to content

Conversation

@realbigsean
Copy link
Member

@realbigsean realbigsean commented Nov 13, 2020

Issue Addressed

Catching up on a few eth2 spec updates:

Proposed Changes

  • adding query params to the GET pool/attestations endpoint
  • allowing the POST pool/attestations endpoint to accept an array of attestations
    • batching attestation submission
  • moving epoch from a path param to a query param in the committees endpoint

Additional Info

@realbigsean realbigsean changed the title Update pool/attestations and committees endpoint Update pool/attestations and committees endpoints Nov 13, 2020
@realbigsean realbigsean marked this pull request as ready for review November 13, 2020 23:05
@realbigsean realbigsean added the ready-for-review The code is ready for review label Nov 13, 2020
@paulhauner paulhauner added the A0 label Nov 16, 2020
Copy link
Member

@paulhauner paulhauner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

bors r+

@paulhauner paulhauner added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Nov 18, 2020
bors bot pushed a commit that referenced this pull request Nov 18, 2020
## Issue Addressed

Catching up on a few eth2 spec updates:

## Proposed Changes

- adding query params to the `GET pool/attestations` endpoint
- allowing the `POST pool/attestations` endpoint to accept an array of attestations
    - batching attestation submission
- moving `epoch` from a path param to a query param in the `committees` endpoint

## Additional Info


Co-authored-by: realbigsean <seananderson33@gmail.com>
@bors
Copy link

bors bot commented Nov 19, 2020

@bors bors bot changed the title Update pool/attestations and committees endpoints [Merged by Bors] - Update pool/attestations and committees endpoints Nov 19, 2020
@bors bors bot closed this Nov 19, 2020
@realbigsean realbigsean deleted the more-standard-api-updates branch November 21, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A0 ready-for-merge This PR is ready to merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants