[Merged by Bors] - Improve UX whilst VC is waiting for genesis #1915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsproul
approved these changes
Nov 22, 2020
Member
michaelsproul
left a comment
michaelsproul
left a comment
There was a problem hiding this comment.
Looks good to me. A nice improvement.
Member
Author
|
Thanks! bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Nov 23, 2020
## Issue Addressed - Resolves #1424 ## Proposed Changes Add a `GET lighthouse/staking` that returns 200 if the node is ready to stake (i.e., `--eth1` flag is present) or a 404 otherwise. Whilst the VC is waiting for the genesis time to start (i.e., when the genesis state is known), check the `lighthouse/staking` endpoint and log an error if the node isn't configured for staking. ## Additional Info NA
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Proposed Changes
Add a
GET lighthouse/stakingthat returns 200 if the node is ready to stake (i.e.,--eth1flag is present) or a 404 otherwise.Whilst the VC is waiting for the genesis time to start (i.e., when the genesis state is known), check the
lighthouse/stakingendpoint and log an error if the node isn't configured for staking.Additional Info
NA