[Merged by Bors] - Add new flag to set blocks per eth1 query #1931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawanjay176
approved these changes
Nov 18, 2020
|
FYI, in Teku we wound up dynamically reducing the number of blocks we request when we get that response (or a timeout) from the Eth1 node: https://github.com/ConsenSys/teku/pull/3182/files#diff-87d531867f3ccf522582e7cc8c12a3b48cb55f90fe6ab1fb6cfb2ac6ee54c28fR225 |
Member
Author
|
Thanks @pawanjay176 for the review and thanks @ajsutton for the feedback. I'll merge this now and we can come back for a better (perhaps dynamic) solution. bors r+ |
paulhauner
added
ready-for-merge
bors bot
pushed a commit
that referenced
this pull request
Nov 18, 2020
## Issue Addressed NA ## Proposed Changes Users on Discord (and @protolambda) have experienced this error (or variants of it): ``` Failed to update eth1 cache: GetDepositLogsFailed("Eth1 node returned error: {\"code\":-32005,\"message\":\"query returned more than 10000 results\"}") ``` This PR allows users to reduce the span of blocks searched for deposit logs and therefore reduce the size of the return result. Hopefully experimentation with this flag can lead to finding a better default value. ## Additional Info NA
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Member
Author
|
I'm told that when syncing Pyrmont, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
NA
Proposed Changes
Users on Discord (and @protolambda) have experienced this error (or variants of it):
This PR allows users to reduce the span of blocks searched for deposit logs and therefore reduce the size of the return result. Hopefully experimentation with this flag can lead to finding a better default value.
Additional Info
NA