[Merged by Bors] - Fix race condition in seen caches #1937
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Squashed commit of the following: commit dc76a33 Author: Paul Hauner <paul@paulhauner.com> Date: Thu Aug 6 11:37:48 2020 +1000 Tighten `BeaconChain` field visibility commit 7c60abd Author: Paul Hauner <paul@paulhauner.com> Date: Thu Aug 6 10:45:26 2020 +1000 Fix test compile errors commit f726abb Author: Paul Hauner <paul@paulhauner.com> Date: Thu Aug 6 10:26:32 2020 +1000 Lift locks for observed operations commit 2332366 Author: Paul Hauner <paul@paulhauner.com> Date: Thu Aug 6 10:14:54 2020 +1000 Lift locks for observed producers commit a99a2dc Author: Paul Hauner <paul@paulhauner.com> Date: Thu Aug 6 07:57:47 2020 +1000 Lift observed attesters locks commit 6093eb9 Author: Paul Hauner <paul@paulhauner.com> Date: Thu Aug 6 07:51:08 2020 +1000 Add more debug logs for block proc. commit 3331751 Author: Paul Hauner <paul@paulhauner.com> Date: Thu Aug 6 07:37:56 2020 +1000 Lift ObservedAttestations locks commit 0f93f9c Author: Paul Hauner <paul@paulhauner.com> Date: Wed Aug 5 15:15:42 2020 +1000 Push naive attns into op pool when producing block commit 4b128ee Author: Paul Hauner <paul@paulhauner.com> Date: Wed Aug 5 15:06:22 2020 +1000 Lift RwLocks out of naive pool
michaelsproul
added
ready-for-review
michaelsproul
added
work-in-progress
michaelsproul
added
ready-for-review
paulhauner
approved these changes
Nov 20, 2020
Member
paulhauner
left a comment
paulhauner
left a comment
There was a problem hiding this comment.
Mmm, so much easier to reason about! Thank you!
I think it would be prudent to test this on a testnet or two before mainnet launch, just to be sure that the extra lock contention doesn't negatively impact performance.
Agree, Pyrmont should be good for that I think. I've run it locally and can't notice a change in CPU usage.
Member
Author
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Nov 22, 2020
## Issue Addressed Closes #1719 ## Proposed Changes Lift the internal `RwLock`s and `Mutex`es from the `Observed*` data structures to resolve the race conditions described in #1719. Most of this work was done by @paulhauner on his `lift-locks` branch, I merely updated it for the current `master` and checked over it. ## Additional Info I think it would be prudent to test this on a testnet or two before mainnet launch, just to be sure that the extra lock contention doesn't negatively impact performance.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
michaelsproul
added
the
consensus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Closes #1719
Proposed Changes
Lift the internal
RwLocks andMutexes from theObserved*data structures to resolve the race conditions described in #1719.Most of this work was done by @paulhauner on his
lift-locksbranch, I merely updated it for the currentmasterand checked over it.Additional Info
I think it would be prudent to test this on a testnet or two before mainnet launch, just to be sure that the extra lock contention doesn't negatively impact performance.