[Merged by Bors] - Fix Syncing Simulator #2049
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot time is below 1 second
blacktemplar
force-pushed
the
fix-simulator-syncing-sim
branch
from
81712ad to
183f4d0
Compare
AgeManning
approved these changes
Dec 16, 2020
Member
AgeManning
left a comment
AgeManning
left a comment
There was a problem hiding this comment.
The changes look fine to me.
I guess adding the syncing sim to the workflow isn't a bad idea. We didn't include it in the past because it was kind of lengthy and not that stable.
I think with our new workflows which should speed up CI there's no harm in adding some more sophisticated tests.
Member
|
bors r+ |
|
Canceled. |
michaelsproul
added
waiting-on-author
michaelsproul
approved these changes
Dec 16, 2020
Member
michaelsproul
left a comment
michaelsproul
left a comment
There was a problem hiding this comment.
Awesome, let's merge
bors r+
michaelsproul
added
ready-for-merge
bors bot
pushed a commit
that referenced
this pull request
Dec 16, 2020
## Issue Addressed NA ## Proposed Changes Fixes problems with slot times below 1 second which got revealed by running the syncing simulator with the default speedup time.
|
Pull request successfully merged into unstable. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
NA
Proposed Changes
Fixes problems with slot times below 1 second which got revealed by running the syncing simulator with the default speedup time.