[Merged by Bors] - add automated release workflow #2077
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AgeManning
approved these changes
Dec 16, 2020
Member
AgeManning
left a comment
AgeManning
left a comment
There was a problem hiding this comment.
Wow. This is really cool!
Should speed some things up. Will be good to test out next release. I'll look into adding the secrets.
Member
|
I'd like to review this before merging, I'll try to get to it soon |
Member
Author
|
I think it'd be a good idea to set up environment secrets: https://docs.github.com/en/free-pro-team@latest/actions/reference/environments If someone tries to access a secret in a new workflow, we could require review before it's run |
…d-release-workflow � Conflicts: � .github/workflows/docker.yml
Member
Since @michaelsproul is on leave, I'll make the call to move forward without his review :) |
paulhauner
approved these changes
Dec 23, 2020
Member
paulhauner
left a comment
paulhauner
left a comment
There was a problem hiding this comment.
Looks good! I've added the secrets to the protected environment. Can't wait to try this out!
bors r+
paulhauner
added
ready-for-merge
bors bot
pushed a commit
that referenced
this pull request
Dec 23, 2020
## Issue Addressed Resolves #1674 ## Proposed Changes - Whenever a tag is pushed with the prefix `v` this workflow is triggered - creates portable and non-portable binaries for linux x86_64, linux aarch64, macOS - an attempt at using github actions caching - signs each binary using GPG - auto-generates full changelog based on commit messages since the last release - creates a **draft** release - hot new formatting (preview [here](https://github.com/realbigsean/lighthouse/releases/tag/v0.9.23)) - has been taking around 35 minutes ## Additional Info TODOs: - Figure out how we should automate dockerhub's version tag. - It'd be quickest just to tag `latest`, but we'd need to make sure the docker workflow completes before this starts - we do the same cross-compile in the `docker` workflow, we could try to use the same binary - integrate a similar flow for unstable binaries (`-rc` tag?) - improve caching, potentially use sccache - if we start using a self-hosted runner this'll require some re-working Need to add the following secrets to Github: - `GPG_PASSPHRASE` - ~~`GPG_PUBLIC_KEY`~~ hard-coded this, because it was tough manage as a secret - `GPG_SIGNING_KEY` Co-authored-by: realbigsean <seananderson33@gmail.com>
Member
|
bors r- I'm going to try and batch this |
|
Canceled. |
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Dec 23, 2020
## Issue Addressed Resolves #1674 ## Proposed Changes - Whenever a tag is pushed with the prefix `v` this workflow is triggered - creates portable and non-portable binaries for linux x86_64, linux aarch64, macOS - an attempt at using github actions caching - signs each binary using GPG - auto-generates full changelog based on commit messages since the last release - creates a **draft** release - hot new formatting (preview [here](https://github.com/realbigsean/lighthouse/releases/tag/v0.9.23)) - has been taking around 35 minutes ## Additional Info TODOs: - Figure out how we should automate dockerhub's version tag. - It'd be quickest just to tag `latest`, but we'd need to make sure the docker workflow completes before this starts - we do the same cross-compile in the `docker` workflow, we could try to use the same binary - integrate a similar flow for unstable binaries (`-rc` tag?) - improve caching, potentially use sccache - if we start using a self-hosted runner this'll require some re-working Need to add the following secrets to Github: - `GPG_PASSPHRASE` - ~~`GPG_PUBLIC_KEY`~~ hard-coded this, because it was tough manage as a secret - `GPG_SIGNING_KEY` Co-authored-by: realbigsean <seananderson33@gmail.com>
|
Pull request successfully merged into unstable. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Resolves #1674
Proposed Changes
vthis workflow is triggeredAdditional Info
TODOs:
latest, but we'd need to make sure the docker workflow completes before this startsdockerworkflow, we could try to use the same binary-rctag?)Need to add the following secrets to Github:
GPG_PASSPHRASEGPG_PUBLIC_KEYGPG_SIGNING_KEY