[Merged by Bors] - fix(validator_client): return http 404 rather than 405 in http api

[duguorong009]

Issue Addressed

• Close Return 404 instead of 405 in VC HTTP API #4596

Proposed Changes

• Add Filter::recover to handle rejections specifically as 404 NOT FOUND

Please list or describe the changes introduced by this PR.

Additional Info

Similar to PR #3836

[CLAassistant]

All committers have signed the CLA.

[michaelsproul]

Looks good. I think you might just need to run cargo fmt --workspace

Lets see if CI passes. Then I'll do some more manual testing, and we can merge.

[duguorong009]

Looks good. I think you might just need to run cargo fmt --workspace

Lets see if CI passes. Then I'll do some more manual testing, and we can merge.

FYI, I ran cargo fmt --all for code.
But, there is no change at all.

Hmm, there is CI failure. I am not much sure why.
Can you let me know what I can do with CI error? @michaelsproul

[michaelsproul]

We can ignore that failure, it's just a flakiness in the tests. I'll double-check with some manual testing then we can merge

[duguorong009]

@michaelsproul @chong-he
Um, can you let me know what stops the merge?
If anything I should do, pls let me know.

[chong-he]

@michaelsproul @chong-he Um, can you let me know what stops the merge? If anything I should do, pls let me know.

It seems ok to me: 0ba06af

Do you see any error?

As a side note I will be doing some testing on this and hope to get back to you soon

[chong-he]

Tested both GET and POST HTTP and it is all good. I think we are good to merge this @michaelsproul

Details:

GET:

curl -X GET "http://localhost:5062/lighthouse/testing" -H "Authorization: Bearer api-token-0x02d34c396c87ddcc0690e3f6b8f7fe23fdf5f309f8569fe9147dc3bf5f445db587" | jq

POST:

DATADIR=/var/lib/lighthouse
curl -X POST http://localhost:5062/lighthouse/testing \
-H "Authorization: Bearer $(cat ${DATADIR}/validators/api-token.txt)" \
-H "Content-Type: application/json" \
-d '[
    {
        "enable": true,
        "description": "validator_one",
        "deposit_gwei": "32000000000",
        "graffiti": "Mr F was here",
        "suggested_fee_recipient": "0xa2e334e71511686bcfe38bb3ee1ad8f6babcc03d"
    },
    {
        "enable": false,
        "description": "validator two",
        "deposit_gwei": "34000000000"
    }
]' | jq

With Lighthouse v4.5.0-441fc16 both returned:

{
  "code": 405,
  "message": "METHOD_NOT_ALLOWED",
  "stacktraces": []
}

With this PR Lighthouse v4.5.0-0ba06af both returned:

{
  "code": 404,
  "message": "NOT_FOUND",
  "stacktraces": []
}

[michaelsproul]

Great, lets merge this.

Sorry for the delay, we had a merge-freeze in effect while v4.5.0 was happening.

[paulhauner]

bors r+

[bors]

Build failed (retrying...):

• release-tests-windows

[bors]

Build failed (retrying...):

• release-tests-ubuntu

[bors]

Build failed:

• release-tests-windows

[paulhauner]

bors r+

[bors]

Pull request successfully merged into unstable.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

• beacon-chain-tests
• cargo-udeps
• check-code
• check-msrv
• compile-with-beta-compiler
• debug-tests-ubuntu
• dockerfile-ubuntu
• doppelganger-protection-test
• ef-tests-ubuntu
• eth1-simulator-ubuntu
• execution-engine-integration-ubuntu
• merge-transition-ubuntu
• no-eth1-simulator-ubuntu
• op-pool-tests
• release-tests-ubuntu
• release-tests-windows
• slasher-tests
• state-transition-vectors-ubuntu
• syncing-simulator-ubuntu