fix path parsing to be cleaned and tested ahead of opening file#275
Merged
bobcallaway merged 1 commit intosigstore:mainfrom Feb 23, 2026
Merged
fix path parsing to be cleaned and tested ahead of opening file#275bobcallaway merged 1 commit intosigstore:mainfrom
bobcallaway merged 1 commit intosigstore:mainfrom
Conversation
Signed-off-by: Bob Callaway <bcallaway@google.com>
cpanato
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a path validation vulnerability in
pkg/config/parser.goby replacing a simple string prefix check with robust path canonicalization and relative path verification.The previous implementation used
strings.HasPrefix(path, basedir), which was vulnerable to two specific bypass techniques:Sibling Directory Bypass:
Paths like
/a/bc/evil.yamlwould incorrectly pass validation against a base directory of/a/bbecause the string prefix matches, even though they are sibling directories.Lack of Canonicalization:
Paths containing traversal sequences like
/safe/dir/../../../etc/passwdwould pass validation against/safe/dirbecause the raw string prefix matches, despite resolving to a location outside the base directory.