[fix, key flow] Explicitly fail on non EC keys#573
Merged
mihaimaruseac merged 2 commits intosigstore:mainfrom Nov 26, 2025
Merged
[fix, key flow] Explicitly fail on non EC keys#573mihaimaruseac merged 2 commits intosigstore:mainfrom
mihaimaruseac merged 2 commits intosigstore:mainfrom
Conversation
The `load_pem_private_key` API reads any type of key, but the internals of the key flow only support elliptic curve keys. This was discovered by a fuzzer that sent an RSA key for verification of a signature generated by an EC key. Signed-off-by: Mihai Maruseac <mihaimaruseac@google.com>
Signed-off-by: Mihai Maruseac <mihaimaruseac@google.com>
spencerschrock
approved these changes
Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
load_pem_private_keyAPI reads any type of key, but the internals of the key flow only support elliptic curve keys. This was discovered by a fuzzer that sent an RSA key for verification of a signature generated by an EC key.Checklist