Fix webhook looking for credentials in the wrong namespace #199
Conversation
Signed-off-by: Andrés Torres <andrest@vmware.com>
Fixes sigstore#143 Signed-off-by: Andrés Torres <andrest@vmware.com>
Signed-off-by: Andrés Torres <andrest@vmware.com>
| defer func() { | ||
| cosignVerifySignatures = cvs | ||
| }() | ||
| // Let's just say that everything is verified. |
There was a problem hiding this comment.
I'm curious if this actually tests that we use the imagepullsecrets from the correct namespace because we use these stubbed out ones. Or if it was modified it's hard to see because this looks like cut&paste from the above tests. Would it maybe be enough to override one of these 'pass' or 'fail' and check in them that the checkopts have indeed the correct secret referenced in them.
There was a problem hiding this comment.
I am not sure if we can test it there because most of the errors I saw were raised when trying to call k8schain.New while passing k8schain.Options without the proper namespace.
vaikas
left a comment
vaikas
left a comment
There was a problem hiding this comment.
Discussed offline and validated that these new tests will fail if the fix is not in.
Thanks @elfotografo007 !!
2 participants
Summary
Extract the namespace from the
AdmissionRequestif the resource doesn't have the namespace field set correctly. Fixes #143.Release Note
imagePullSecretswere involved.Documentation