Skip to content

Conversation

@vaikas
Copy link
Collaborator

@vaikas vaikas commented Aug 29, 2022

  • Add explicit check for invalid keys. This should not happen, but.
  • Add explicit check to make sure there's a publickey, again ☝️
  • Fail if config file is incorrect.

Signed-off-by: Ville Aikas vaikas@chainguard.dev

Summary

Release Note

  • Add an explicit check and fail if config does not contain valid inline data. This should not happen because the keys get validated before serializing them into the configmap.
  • Add an explicit check for when a KeyRef does not contain a valid PublicKey. Prior to this it would have been mistakenly flagged as not having a KeyRef, Static of KeylessRef.

Documentation

@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2022

Codecov Report

Merging #200 (4ded3d9) into main (c0ba5b3) will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #200      +/-   ##
==========================================
+ Coverage   63.44%   63.55%   +0.10%     
==========================================
  Files          26       26              
  Lines        2421     2420       -1     
==========================================
+ Hits         1536     1538       +2     
+ Misses        807      805       -2     
+ Partials       78       77       -1     
Impacted Files Coverage Δ
pkg/webhook/validator.go 78.20% <100.00%> (-0.04%) ⬇️
pkg/apis/config/image_policies.go 73.33% <0.00%> (+6.66%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

* Add explicit check to make sure there's a publickey, again :point-up:
* Fail if config file is incorrect.

Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
@vaikas vaikas force-pushed the check-keys-inlined branch from 55c2c4f to 4ded3d9 Compare August 29, 2022 21:30
@cpanato cpanato requested a review from hectorj2f August 30, 2022 15:27
@vaikas vaikas merged commit e3058a0 into sigstore:main Aug 30, 2022
@vaikas vaikas deleted the check-keys-inlined branch August 30, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants