VER-905: wifi: ath12k: add logs to debug "HTC Rx: invalid eid" log spam#83
Merged
adrian-nicolau merged 4 commits intoMay 11, 2026
Merged
Conversation
adrian-nicolau
changed the title
There was a problem hiding this comment.
Pull request overview
This PR aims to improve diagnosability of ath12k “HTC Rx: invalid eid” log spam and related RX-path anomalies by adding more contextual logging (descriptor/payload snippets and IDs) at key failure points in HTC, CE, DP RX, MAC, and HAL SRNG access paths.
Changes:
- Add hexdump-style context to several RX error/warn logs (HTC payload snippets, RX desc first bytes, CE status desc raw words).
- Extend firmware-stats timeout warning to include pdev/vdev/stats identifiers.
- Add sanity checks around SRNG HW pointers (hp/tp) and CE receive lengths/NULL skb cases.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| drivers/net/wireless/ath/ath12k/wifi7/dp_rx.c | Adds descriptor-byte context to RX warnings; minor log text updates. |
| drivers/net/wireless/ath/ath12k/mac.c | Improves fw-stats timeout warning with request identifiers. |
| drivers/net/wireless/ath/ath12k/htc.c | Adds additional warning logs with HTC header fields and payload snippet on malformed RX frames. |
| drivers/net/wireless/ath/ath12k/hal.c | Adds bounds checks for SRNG hp/tp reads in access_begin(). |
| drivers/net/wireless/ath/ath12k/ce.c | Adds extra CE RX validation/logging (0-length, NULL skb, too-short frame) and adjusts warning messaging. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
michaeln-ceragon
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to improve diagnosability of ath12k "HTC Rx: invalid eid" log spam and related RX-path anomalies by adding more contextual logging (descriptor/payload snippets and IDs) at key failure points in HTC, CE, DP RX, MAC, and HAL SRNG access paths.