Release 2.15.3: Code quality improvements #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The composer.json version must match the release version in order for packagist to pick it up.
if (condition) { return true; } else { return false; }
can be reduced to:
return condition;
Less return statements is easier to debug, and makes Sonar
Qube happy.
Corrected 3 return statements which were of the form return (condition); There is no need for the ()'s.
Created a constant for when group insert fails. It is a template, so it can be used in an sprintf().
assertEquals(a,b,msg) is better code than assertTrue(a === b, msg).
assertSame supposedly does type checking too.
When the group does or does not exist, that may cause an exception.
PHP files generally should end on a new line.
It doesn't make sense to try to update Group Settings when there aren't Group Settings to update.
By setting the permissions of the copied files and ending with USER 1000, a non-privileged user should be used
Sure I have to change, but I end with non-root too!
This should be safer.
This will avoid accidentally copying git development things, jetbrain IDE things, etcetera into the docker container.
Merging RUN commands where possible, and use WORKDIR instead of "cd"
mtompset
requested review from
a team,
briskt,
ethancanne,
forevermatt and
jason-jackson
and removed request for
a team
forevermatt
approved these changes
Mar 25, 2025
|
forevermatt
reviewed
Apr 1, 2025
| chmod 664 /data/SilMock/tests/.phpunit.result.cache | ||
|
|
||
| WORKDIR /data | ||
| RUN ./composer-install.sh && mv /data/composer.phar /usr/bin/composer |
Contributor
There was a problem hiding this comment.
If at some point you want to simplify this (to possibly get rid of the need for a composer-install.sh script), you can also just copy the composer binary from their Docker image, like so:
COPY --from=composer:2 /usr/bin/composer /usr/local/bin/composer
You can use whatever version tag you want to, after the colon in that --from parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
Fix