Skip to content

use the authenticated Key as the "old" key for the rotation endpoint #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 5, 2025
Merged

use the authenticated Key as the "old" key for the rotation endpoint #158

merged 2 commits into from
Nov 5, 2025

Conversation

@briskt
Copy link
Contributor

@briskt briskt commented Nov 4, 2025

IDP-1731 Use the MFA API authentication key for key rotation

Changed

  • Since the /api-key/rotate endpoint is now authenticated with an active key, it's better to use that key as the "old key" rather than expect it to be duplicated in the request body.

@briskt briskt requested review from a team as code owners November 4, 2025 06:25
@briskt briskt requested review from ethancanne, hobbitronics, jason-jackson and mtompset and removed request for a team November 4, 2025 06:25
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 4, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

hobbitronics
hobbitronics approved these changes Nov 5, 2025
View reviewed changes
Copy link

@hobbitronics hobbitronics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@briskt briskt merged commit 5c66fbc into develop Nov 5, 2025
6 checks passed
@briskt briskt deleted the simplify-rotate branch November 5, 2025 07:57
@briskt briskt mentioned this pull request Nov 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hobbitronics hobbitronics hobbitronics approved these changes

@ethancanne ethancanne Awaiting requested review from ethancanne ethancanne is a code owner automatically assigned from sil-org/go-devs

@jason-jackson jason-jackson Awaiting requested review from jason-jackson jason-jackson is a code owner automatically assigned from sil-org/go-devs

@mtompset mtompset Awaiting requested review from mtompset mtompset is a code owner automatically assigned from sil-org/developers

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@briskt @hobbitronics