Skip to content

Release 3.2.0 - Final changes on the key rotation process #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Nov 21, 2025
Merged

Release 3.2.0 - Final changes on the key rotation process #161

merged 13 commits into from
Nov 21, 2025

Conversation

@briskt
Copy link
Contributor

@briskt briskt commented Nov 19, 2025

Changed

  • Monitor the request context for API key rotation and fail gracefully so the completion stats are still reported. (IDP-1735)
  • Changed the response body schema for the key rotation endpoint. It is now more structured.
  • Since the /api-key/rotate endpoint is now authenticated with an active key, it's better to use that key as the "old key" rather than expect it to be duplicated in the request body. (IDP-1731)
  • Don't use naked returns.

Added

  • Include all ApiKey metadata properties in the response to ActivateApiKey. This just makes it more RESTful.

Fixed

  • Update Terraform AWS provider in f33d02a.
  • Fix an error in the OpenAPI spec in f3dea81.

Most of this was reviewed in #157, #158, and #159. Only the last two commits were direct to develop: f33d02a, f3dea81

briskt added 13 commits November 3, 2025 15:49
@briskt
add the full object response to ActivateApiKey
21ee80f
@briskt
check createdAt
d13ec3d
@briskt
use the authenticated Key as the "old" key for the rotation endpoint
c5950bc
@briskt
Merge pull request #157 from sil-org/activate-response
bddd35a 
add the full object response to ActivateApiKey
@briskt
Merge branch 'develop' into simplify-rotate
45e52a9
@briskt
Merge pull request #158 from sil-org/simplify-rotate
5c66fbc 
use the authenticated Key as the "old" key for the rotation endpoint
@briskt
monitor the requests context for API key rotation and fail gracefully
724feb7
@briskt
try 1000 since GitHub Actions can rotate 100 in one second
b0b324a
@briskt
update the openapi spec with the new response schema for key rotation
03d3a85
@briskt
Merge pull request #159 from sil-org/feature/improve-rotate
ca8add5 
improve key rotatation
@briskt
Merge remote-tracking branch 'origin/main' into develop
075a5b5
@briskt
update aws provider
f33d02a
@briskt
correct openapi.yaml http method error
f3dea81
@briskt briskt requested review from a team as code owners November 19, 2025 11:31
@briskt briskt requested review from ethancanne, hobbitronics, jason-jackson and mtompset and removed request for a team November 19, 2025 11:31
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 19, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@briskt briskt merged commit 915e22b into main Nov 21, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jason-jackson jason-jackson jason-jackson approved these changes

@ethancanne ethancanne Awaiting requested review from ethancanne ethancanne is a code owner automatically assigned from sil-org/go-devs

@hobbitronics hobbitronics Awaiting requested review from hobbitronics hobbitronics is a code owner automatically assigned from sil-org/go-devs

@mtompset mtompset Awaiting requested review from mtompset mtompset is a code owner automatically assigned from sil-org/developers

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@briskt @jason-jackson