Skip to content

improve key rotatation #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 6, 2025
Merged

improve key rotatation #159

merged 3 commits into from
Nov 6, 2025

Conversation

@briskt
Copy link
Contributor

@briskt briskt commented Nov 5, 2025 •
edited
Loading

IDP-1735 MFA API key rotation does not fail gracefully

Changed

  • Monitor the request context for API key rotation and fail gracefully so the completion stats are still reported.
  • Changed the response body schema for the key rotation endpoint. It is now more structured.
  • Don't use naked returns.

@briskt briskt requested review from a team as code owners November 5, 2025 08:15
@briskt briskt requested review from ethancanne, forevermatt, hobbitronics and jason-jackson and removed request for a team November 5, 2025 08:15
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 5, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@briskt briskt merged commit ca8add5 into develop Nov 6, 2025
6 checks passed
@briskt briskt deleted the feature/improve-rotate branch November 6, 2025 00:17
@briskt briskt mentioned this pull request Nov 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jason-jackson jason-jackson jason-jackson approved these changes

@ethancanne ethancanne Awaiting requested review from ethancanne ethancanne is a code owner automatically assigned from sil-org/go-devs

@hobbitronics hobbitronics Awaiting requested review from hobbitronics hobbitronics is a code owner automatically assigned from sil-org/go-devs

@forevermatt forevermatt Awaiting requested review from forevermatt forevermatt is a code owner automatically assigned from sil-org/developers

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@briskt @jason-jackson