Skip to content
This repository was archived by the owner on Jun 25, 2024. It is now read-only.

Add logo caption#115

Merged
hobbitronics merged 12 commits intodevelopfrom
feature/logoCaption
Nov 21, 2022
Merged

Add logo caption#115
hobbitronics merged 12 commits intodevelopfrom
feature/logoCaption

Conversation

@hobbitronics
Copy link
Copy Markdown
Contributor

@hobbitronics hobbitronics commented Nov 17, 2022 •
edited
Loading

@hobbitronics hobbitronics requested review from a team November 17, 2022 03:53
Baggerone
Baggerone reviewed Nov 17, 2022
View reviewed changes
Comment thread themes/material/default/selectidp-links.php Outdated
@Baggerone
Copy link
Copy Markdown
Contributor

Baggerone commented Nov 18, 2022

@hobbitronics
I hope you don't mind. I merged in some changes just to add the Partners IdP and remove one of the wga IdP entries.

Baggerone
Baggerone reviewed Nov 18, 2022
View reviewed changes
Comment thread themes/material/default/selectidp-links.php Outdated
height: 130px;
}
.logo-caption {
text-transform: capitalize;
Copy link
Copy Markdown
Contributor

@Baggerone Baggerone Nov 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One drawback of this appears to be that "Partners of SIL" gets changed to "Partners Of SIL". I doubt if we want that.

Copy link
Copy Markdown
Contributor

@forevermatt forevermatt Nov 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. Let's not use CSS to change the capitalization, but just show the text that was given.

Copy link
Copy Markdown
Contributor Author

@hobbitronics hobbitronics Nov 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that.

forevermatt
forevermatt reviewed Nov 18, 2022
View reviewed changes
Comment thread themes/material/default/selectidp-links.php Outdated
hobbitronics and others added 2 commits November 19, 2022 06:49
@hobbitronics
remove capitalize
ca8e802
@hobbitronics @forevermatt
encode caption
d7c01ba 
Co-authored-by: forevermatt <forevermatt@users.noreply.github.com>
@hobbitronics
Copy link
Copy Markdown
Contributor Author

hobbitronics commented Nov 18, 2022

@hobbitronics I hope you don't mind. I merged in some changes just to add the Partners IdP and remove one of the wga IdP entries.

Not at all.

forevermatt
forevermatt approved these changes Nov 18, 2022
View reviewed changes
Comment thread development/hub2/saml20-idp-remote.php Outdated
@hobbitronics @forevermatt
Update development/hub2/saml20-idp-remote.php
12985cf 
Co-authored-by: forevermatt <forevermatt@users.noreply.github.com>
@hobbitronics hobbitronics merged commit 8a8e0ef into develop Nov 21, 2022
@hobbitronics hobbitronics deleted the feature/logoCaption branch November 21, 2022 05:57
briskt added a commit to sil-org/ssp-base that referenced this pull request May 29, 2024
@briskt
add logo caption
6ccbb26 
sil-org/simplesamlphp-module-material#115
sil-org/simplesamlphp-module-material#121
sil-org/simplesamlphp-module-material#123
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Baggerone Baggerone Awaiting requested review from Baggerone

1 more reviewer

@forevermatt forevermatt forevermatt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hobbitronics @Baggerone @forevermatt