Skip to content
This repository was archived by the owner on Jun 25, 2024. It is now read-only.

Running out of backup codes#47

Merged
longrunningprocess merged 9 commits into
developfrom
running-out-of-backup-codes
Jan 16, 2018
Merged

Running out of backup codes#47
longrunningprocess merged 9 commits into
developfrom
running-out-of-backup-codes

Conversation

@longrunningprocess
Copy link
Copy Markdown
Contributor

No description provided.

Comment thread dictionaries/mfa.definition.json Outdated
"running_out_header": {
"en": "Almost out of printable codes",
"es": "Casi sin códigos imprimibles",
"fr": "Presque en dehors des codes imprimables",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codes imprimables presque épuisés

Comment thread dictionaries/mfa.definition.json Outdated
"running_out_info": {
"en": "You only have {numBackupCodesRemaining} more left.",
"es": "Solo tienes {numBackupCodesRemaining} más a la izquierda.",
"fr": "Vous avez seulement {numBackupCodesRemaining} plus à gauche.",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vous avez seulement {numBackupCodesRemaining} qui restent.

Comment thread dictionaries/mfa.definition.json Outdated
"has_no_more_options": {
"en": "Since you do not have any other 2-Step Verification options set up at this time, you should create more Printable codes now so you will have some the next time one is required.",
"es": "Como no tiene configuradas otras opciones de verificación en dos pasos en este momento, debe crear más códigos imprimibles ahora para tenerlos la próxima vez que los necesite.",
"fr": "Comme aucune autre option de vérification en deux étapes n'est configurée pour le moment, vous devez créer d'autres codes imprimables maintenant, de sorte que vous en aurez d'autres la prochaine fois que vous en aurez besoin.",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comme aucune autre option de vérification en deux étapes n'est configurée pour le moment, vous devriez créer d'autres codes imprimables maintenant, pour que vous en aurez la prochaine fois que vous en aurez besoin.

@longrunningprocess
Copy link
Copy Markdown
Contributor Author

Thanks @Baggerone , I've made those French changes.

Copy link
Copy Markdown
Contributor

@forevermatt forevermatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some comments/questions, but nothing blocking. If you decide none of the issues I mentioned need fixed, I'm fine with this PR being merge.

Comment thread dictionaries/mfa.definition.json Outdated
},
"running_out_info": {
"en": "You only have {numBackupCodesRemaining} more left.",
"es": "Solo tienes {numBackupCodesRemaining} más a la izquierda.",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure "... a la izquierda" is correct. It may genuinely be the way to say it in Spanish, but literally I think that means "... to the left". If we do get a Spanish-speaker to check this, it may be worth asking them if there's a single phrasing that works for 1, for 2, and for 3 codes left (in case the singular/plural changes affect the translation).

Copy link
Copy Markdown
Contributor Author

@longrunningprocess longrunningprocess Jan 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll be having Steve W do it and will bring it up to him, thanks.

Comment thread README.md Outdated
6. Click **idp2**
7. Forgot password link should be visible
1. Login as hub administrator: `username=`**admin** `password=`**abc123**
11. Click **Authentication** tab
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like an extra 1 snuck in here (should be 1, not 11).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

Comment thread dictionaries/mfa.definition.json Outdated
"ko": "고맙게도 다른 2 단계 인증 옵션을 설정했는데 나중에 필요할 경우 더 많은 인쇄용 코드를 만들어야합니다."
},
"has_no_more_options": {
"en": "Since you do not have any other 2-Step Verification options set up at this time, you should create more Printable codes now so you will have some the next time one is required.",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would you think about using "you need to create more" rather than "you should create more" here? I'm just thinking that "should" seems like merely a strong recommendation, not a requirement, but at this point they have no other choice available to them.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gotcha, yep, I'll change the tone.

@longrunningprocess
Copy link
Copy Markdown
Contributor Author

longrunningprocess commented Jan 12, 2018

ok @forevermatt , those are in

"es": "Como no tiene configuradas otras opciones de verificación en dos pasos en este momento, debe crear más códigos imprimibles ahora para tenerlos la próxima vez que los necesite.",
"fr": "Comme aucune autre option de vérification en deux étapes n'est configurée pour le moment, vous devriez créer d'autres codes imprimables maintenant, pour que vous en aurez la prochaine fois que vous en aurez besoin.",
"ko": "현재 다른 2 단계 인증 옵션을 설정하지 않았으므로 인쇄용 코드를 더 만들어야 만 다음에 필요할 때 사용할 수 있습니다."
"en": "Since you do not have any other 2-Step Verification options set up at this time, you will need to get more Printables code before another one is required.",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo (I don't know if/how it will have affected the translations):
Printables code --> Printable Codes (the 's' was in the wrong place)

@longrunningprocess longrunningprocess merged commit 637c7f2 into develop Jan 16, 2018
@longrunningprocess longrunningprocess deleted the running-out-of-backup-codes branch January 16, 2018 14:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants