Set APK name explicitly#80
Merged
silbinarywolf merged 1 commit intosilbinarywolf:mainfrom Apr 12, 2026
Merged
Conversation
Contributor
ypsvlq
commented
Apr 8, 2026
ypsvlq
commented
- Prevents link issues caused by renaming a library but not changing its SONAME
- Allows multiple artifacts to be added for the same architecture
- Fixes consider not hard-coding lib names #39
silbinarywolf
requested changes
Apr 9, 2026
Owner
silbinarywolf
left a comment
silbinarywolf
left a comment
There was a problem hiding this comment.
Looks good to me, thanks for doing this!
If you could please just add a couple of comments making it clear on what the name option does, then I'll approve!
Owner
|
Awesome, thank you for this :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.