Skip to content

make default aligned page size 16kb #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
silbinarywolf merged 2 commits into from
Apr 23, 2026
+13 −0
Merged

make default aligned page size 16kb #88

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dee32a0
make default aligned page size 16kb
silbinarywolf Apr 22, 2026
2c756d0
improve comment
silbinarywolf Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/androidbuild/Apk.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -796,6 +796,19 @@ fn setLibCFile(apk: *Apk, compile: *Step.Compile) void {
fn updateArtifact(apk: *Apk, artifact: *Step.Compile, raw_top_level_apk_files: *Step.WriteFile) void {
const b = apk.b;

// Set page size to 16KB-aligned binaries by default
//
// For Android NDK r27 onwards, Android recommends the following setting by default
// Source: https://developer.android.com/guide/practices/page-sizes#compile-r27
//
// NOTE(jae): 2026-04-23
// Zig 0.16.0 stable does not do this by default and without this line, there is a pop-up
// warning when testing on Pixel 10, Android 17 VM device.
// Screenshot is on Github issue here: https://github.com/silbinarywolf/zig-android-sdk/issues/87
if (artifact.link_z_max_page_size == null) {
artifact.link_z_max_page_size = 16384;
}

// If you have a library that is being built as an *.so then install it
// alongside your library.
//
Expand Down
Loading