Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements support for multi-valued comprehensions as specified in EEP-78, allowing multiple elements to be emitted per iteration in list and map comprehensions.
Changes
children()method forComprehensionExpr<Open, Close, NonEmptyItems<Expr>>to iterate over all expression and qualifier childrenListComprehensionExprto useNonEmptyItems<Expr>to support multiple value expressions[Expr, ...]MapComprehensionExprto useNonEmptyItems<MapComprehensionValue>for multiple entries per iterationchildren()method for map comprehensions that flattens multiple key-value pairsThese changes enable syntax like
[X, Y || X <- Xs, Y <- Ys]and#{K1 => V1, K2 => V2 || ...}while maintaining backwards compatibility with single-valued comprehensions.