Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements parser and formatter support for Erlang EEP 79 native records, which introduces an alternative record syntax with module qualification and anonymous record operations.
Key Changes
Record Expressions (
expressions/records.rs):RecordNamestruct to accept atoms, keywords, or variables as record names (excluding underscore)QualifiedRecordNamestruct to support module-qualified names like#mod:state{}RecordNameRefenum to handle both named and anonymous (#_{}) record referencesRecordConstructExpr,RecordIndexExpr, andRecordUpdateExprto use the new name typesRecord Declarations (
forms.rs):RecordDeclinto two variants:TupleRecordDecl(traditional syntax) andNativeRecordDecl(new syntax)NativeRecordNamestruct (similar to expression names)-record #Name(TVar1, ...) { fields }.is_native()andtype_params()Import Changes:
Eitherimport fromexpressions.rsColonSymbolandSharpSymbolimports toforms.rsKeywordTokenimports where neededThis implementation aligns with EEP 79 specification while maintaining backward compatibility with existing tuple-based record syntax.