Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request enhances the extracurricular activities feature by adding new activities, improving activity signup validation, and significantly upgrading the user interface to display participant lists and modernize the layout. The changes span backend data, API logic, frontend rendering, and styling.
Backend changes:
activitiesdata structure insrc/app.py, each with detailed information and initial participants.signup_for_activityfunction insrc/app.pyto prevent students from signing up for the same activity more than once by raising an error if already registered.Frontend logic and display:
src/static/app.jsby introducing acreateActivityElementfunction that displays each activity along with a participant list, showing either current participants or a placeholder if none exist. [1] [2]Styling and layout improvements:
src/static/index.htmlto use a grid layout for better visual organization.src/static/styles.cssto support the new grid layout, improve the appearance of activity cards, and style the participants section and list for clarity and modern aesthetics. [1] [2]