-
Notifications
You must be signed in to change notification settings - Fork 1
[Docs] Added Syntax Coverage Draft #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added documentation which describes the set of SDC syntax we are hoping to support for this test suite. This is a first draft and is subject to review.
WalkthroughAdds comprehensive SDC (Synopsys Design Constraints) syntax documentation to Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/syntax/README.md(1 hunks)
🧰 Additional context used
🪛 LanguageTool
docs/syntax/README.md
[style] ~40-~40: In contexts where ‘if’ is followed by ‘or’, using ‘whether’ may be more appropriate (and formal).
Context: ... flag called "-exclusive". Should check if we want this or not. ### set_false_pat...
(IF_WHETHER)
🪛 markdownlint-cli2 (0.18.1)
docs/syntax/README.md
7-7: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
17-17: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
31-31: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
44-44: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
58-58: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
69-69: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
80-80: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
92-92: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
105-105: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
118-118: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
131-131: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
145-145: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
🔇 Additional comments (1)
docs/syntax/README.md (1)
27-27: Clarify pending decisions in documentation notes.Lines 27, 40, 54, and 141 contain notes deferring decisions about command options (e.g., "Should confirm if we want to support them", "Should check if we want this or not"). Since this is documented as a first draft, clarify whether these are:
- Acceptable TODOs for a draft document pending team consensus
- Blocking items requiring resolution before merge
- Tracked in a separate issue or discussion
Additionally, line 40 could be reworded for formality: replace "Should check if we want" with "Should check whether we want" for more formal context.
Also applies to: 40-40, 54-54, 141-141
Added documentation which describes the set of SDC syntax we are hoping to support for this test suite.
This is a first draft and is subject to review.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.