Fix LT-22265: If there are new 'common' columns show them by default (#486)

Author: jasonleenaylor

Src/Common/Controls/XMLViews/XmlBrowseViewBaseVc.cs

@@ -224,11 +224,26 @@ public XmlBrowseViewBaseVc(XmlNode xnSpec, int fakeFlid, XmlBrowseViewBase xbv)
 			}
 			else
 			{
+				var newPossibleColumns = new List<XmlNode>(m_possibleColumns);
 				foreach (XmlNode node in doc.DocumentElement.SelectNodes("//column"))
 				{
+
+					// if there is a corresponding possible column, remove it from the newPossibleColumns list.
+					var possible = newPossibleColumns.Find(n =>
+						XmlUtils.GetOptionalAttributeValue(n, "label", "") ==
+						XmlUtils.GetOptionalAttributeValue(node, "label", "NONE"));
+					if (possible != null)
+						newPossibleColumns.Remove(possible);
 					if (IsValidColumnSpec(node))
 						m_columns.Add(node);
 				}
+
+				foreach (var node in newPossibleColumns)
+				{
+					// add any possible columns that were not in the saved list and are common
+					if (XmlUtils.GetOptionalAttributeValue(node, "common", "false") == "true")
+						m_columns.Add(node);
+				}
 			}
 			m_fakeFlid = fakeFlid;
 			SetupSelectColumn();