No more calling PHP code from LfMerge#175
Merged
Merged
Conversation
This is the first step towards being able to get rid of the RunClass code and not have our C# code call our PHP code.
Now that the MongoConnection knows how to update role views and user views, this is no longer needed at all.
Did a bit of debugging and found that in addition to MultiString, we can have a field type of String coming from FieldWorks for a custom field of the most common type, which should convert to "multistring" in LF.
megahirt
approved these changes
Dec 8, 2021
Contributor
megahirt
left a comment
megahirt
left a comment
There was a problem hiding this comment.
Reviewed 15 of 15 files at r1, all commit messages.
Reviewable status:complete! 1 of 1 LGTMs obtained (waiting on @rmunn)
The logic from this method has moved into MongoConnection
This wasn't needed in the master branch version of this change, where it uses the modern .NET build system that doesn't need a list of every file. But here in the fieldworks8-master branch, the .csproj file includes a list of every file in the project, so when we delete a file we also need to remove it from the .csproj list as well.
Just like with the deleted files, this wasn't necessary in the master branch but is necessary in the fieldworks8-master branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR finally implements the updateCustomFieldViews logic in LfMerge, as part of the SetCustomFieldConfig method in MongoConnection (which is where the logic belongs anyway). This will allow us to move the
lfmergepackage into its own container in Language Forge, instead of having it so tightly coupled to the PHP container.This is PR #173 but against fieldworks8-master rather than master.
This change is