SP630 audio video out of sync4 android12#634
Merged
bryanwussow merged 2 commits intosillsdev:developfrom Apr 4, 2022
Merged
Conversation
This was referenced Apr 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per issue #630, update software to proper keep audio and slides in sync.
During Android 12 testing, the encoding of the audio to the slides was out of sync, ie,
the slide video finished earlier than the audio track. This produced a video with the
audio being played over the wrong slide.
The origin code assumed the encoder for a codec mime type (eg, "video/avc") would always
properly encode the video. As it turns out, there can be more than one encoder for
a mime type, so, picking the first encoder in the list may not produce the desired
video. The code was updated to look for a codec encoder with a specific canonical name that
has always worked for us in the past.
The following test procedure was run:
Results:
Audio matched the video through the story.
Other combinations of videos were made using background music and text. Videos created by these various combinations of video creation options correctly synced the audio to the video.
The testing was performed on the following configurations:
Pixel 5 Hardware, API 31
Samsung Hardware, API 29
Samsung Hardware, API 28