Skip to content

Conversation

@imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Aug 12, 2025

Fixes #3543 without even touching an audio/pronunciations file.

Both EditCell and PronunciationsCell (via the confirm prop) use replaceWord from their parent ReviewEntriesTable, so this pr pulls the goal-history-updating dispatch out of EditCell and executes it within replaceWord (where it really should have been in the first place).


This change is Reviewable

@codecov
Copy link

codecov bot commented Aug 12, 2025

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.12%. Comparing base (ca31e32) to head (64b38ab).
⚠️ Report is 19 commits behind head on master.

Files with missing lines Patch % Lines
src/goals/Redux/GoalActions.ts 0.00% 4 Missing ⚠️
...c/goals/ReviewEntries/ReviewEntriesTable/index.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3926      +/-   ##
==========================================
- Coverage   74.15%   74.12%   -0.04%     
==========================================
  Files         288      288              
  Lines       10621    10620       -1     
  Branches     1327     1327              
==========================================
- Hits         7876     7872       -4     
- Misses       2359     2362       +3     
  Partials      386      386              
Flag Coverage Δ
backend 85.43% <ø> (ø)
frontend 65.52% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit b518748 into master Aug 12, 2025
19 checks passed
@imnasnainaec imnasnainaec deleted the bugfix/review-entries-edit-history branch August 12, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add/remove audio doesn't show up in completed Review Entries

3 participants