Skip to content

Bump aws-kubectl to 0.4.2 to nix useless variable#4242

Merged
imnasnainaec merged 1 commit intomasterfrom
aws-kubectl-0.4.2
Apr 1, 2026
Merged

Bump aws-kubectl to 0.4.2 to nix useless variable#4242
imnasnainaec merged 1 commit intomasterfrom
aws-kubectl-0.4.2

Conversation

@imnasnainaec
Copy link
Copy Markdown
Collaborator

@imnasnainaec imnasnainaec commented Mar 31, 2026

Uses: sillsdev/aws-kubectl#8


This change is Reviewable

Summary by CodeRabbit

  • Chores
    • Removed Docker email configuration requirement from AWS ECR login setup, simplifying deployment configuration.
    • Updated AWS kubectl container image to version 0.4.2 across maintenance and automation configurations.

@imnasnainaec imnasnainaec self-assigned this Mar 31, 2026
@imnasnainaec imnasnainaec added the 🟩Low Low-priority PR label Mar 31, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 31, 2026

📝 Walkthrough

Walkthrough

This PR removes the unused DOCKER_EMAIL environment variable from AWS ECR login Helm templates and ConfigMaps, while updating the aws-kubectl container image version from 0.4.1 to 0.4.2 across Helm charts and the maintenance Dockerfile.

Changes

Cohort / File(s) Summary
AWS Login Helm Templates
deploy/helm/aws-login/templates/aws-ecr-login-cronjob.yaml, deploy/helm/aws-login/templates/aws-ecr-login-oneshot.yaml
Removed DOCKER_EMAIL environment variable references from CronJob and Job container specs.
AWS Login Helm Configuration
deploy/helm/aws-login/templates/aws-login-config.yaml, deploy/helm/aws-login/values.yaml
Removed DOCKER_EMAIL key from ConfigMap template and dockerEmail value from Helm values chart.
Image Version Updates
deploy/helm/aws-login/values.yaml, deploy/helm/thecombine/charts/maintenance/values.yaml, maintenance/Dockerfile
Updated aws-kubectl container image version from 0.4.1 to 0.4.2 across Helm charts and Dockerfile.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested labels

deployment, docker

Suggested reviewers

  • jasonleenaylor

Poem

🐰 An email removed with a hop and a bound,
Old Docker configs no longer around,
Version bumped up, 0.4.2 in sight,
Deployment scripts dancing, everything tight! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: bumping aws-kubectl to 0.4.2 and removing the useless DOCKER_EMAIL variable across all configuration files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch aws-kubectl-0.4.2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.94%. Comparing base (e810293) to head (45ebab6).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4242   +/-   ##
=======================================
  Coverage   75.94%   75.94%           
=======================================
  Files         303      303           
  Lines       11352    11352           
  Branches     1407     1407           
=======================================
  Hits         8621     8621           
  Misses       2330     2330           
  Partials      401      401           
Flag Coverage Δ
backend 87.23% <ø> (ø)
frontend 66.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@jasonleenaylor reviewed 6 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on imnasnainaec).

@imnasnainaec imnasnainaec merged commit 7537ad8 into master Apr 1, 2026
23 checks passed
@imnasnainaec imnasnainaec deleted the aws-kubectl-0.4.2 branch April 1, 2026 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants