TT-7022 Add CHAPTERNUMBER passage type handling and graphic rendering to PassageCard #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for CHAPTERNUMBER passage types and implements graphic rendering capabilities for both NOTE and CHAPTERNUMBER types in the PassageCard component. The implementation includes displaying avatar graphics (either from a URI or generated from text), showing chapter comments inline with the title, and providing a simplified layout for CHAPTERNUMBER cards without assignment information or step buttons.
Changes:
- Added Avatar component with graphic rendering support for NOTE and CHAPTERNUMBER passage types
- Implemented CHAPTERNUMBER-specific layout that displays comments inline with the title and positions audio controls centrally
- Added comprehensive test coverage for both CHAPTERNUMBER rendering and graphic avatar functionality
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/renderer/src/components/Sheet/PassageCard.tsx | Adds getGraphicValue() function to render avatars for NOTE/CHAPTERNUMBER types, implements conditional rendering for CHAPTERNUMBER layout with inline comments and centered audio controls, and imports Avatar component and stringAvatar utility |
| src/renderer/src/components/Sheet/PassageCard.cy.tsx | Adds comprehensive test suites for CHAPTERNUMBER passage type behavior and graphic rendering functionality, including tests for avatar display, border styling, and passage type-specific rendering |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
… to PassageCard - Add PlayButton component and integrate into PassageCard for media playback control - Add handling for CHAPTERNUMBER comments in PassageCard component
gtryus
force-pushed
the
feature/TT-7022-chapter-card
branch
from
97baa4a to
9872023
Compare
sarahentzel
approved these changes
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.