Skip to content

TT-7335 Improve aesthetics of racetrack UI#314

Merged
gtryus merged 13 commits into
sillsdev:developfrom
nghtctrl:TT-7335
May 20, 2026
Merged

TT-7335 Improve aesthetics of racetrack UI#314
gtryus merged 13 commits into
sillsdev:developfrom
nghtctrl:TT-7335

Conversation

@nghtctrl
Copy link
Copy Markdown

@nghtctrl nghtctrl commented May 19, 2026

Changes:

  • Make the parallelograms (i.e., racetrack) bigger
  • Add dropdown for passage navigation (and make sure it works differently depending on the passage progression mode) -- the actual button styling will need to be adjusted by theme control, which is out of scope for this PR
  • Fix how the racetrack centers itself on bigger screens (e.g., tablets and laptop screens)

Before:
Before

After:
After

@nghtctrl nghtctrl changed the title TT-7335 TT-7335 Improve aesthetics of racetrack UI May 19, 2026
@nghtctrl nghtctrl marked this pull request as ready for review May 19, 2026 18:32
Comment thread src/renderer/src/components/PassageDetail/mobile/MobileWorkflowSteps.tsx Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Improves the mobile racetrack (workflow step) UI: enlarges the parallelogram step indicators, adds a placeholder passage-navigation dropdown beside them, and adjusts layout so the racetrack stays centered on wider screens via a mirroring spacer.

Changes:

  • Resize step indicators to 80×30 with a clipPath parallelogram, overlap edges, and reformat the centered label/tip.
  • Add a passage-selection Button+Menu (book/reference) that, when an item is chosen, persists the current passage and navigates via usePassageNavigate.
  • Track the dropdown width with useLayoutEffect+ResizeObserver and render a matching spacer so mx:auto centers the parallelograms.

Comment thread src/renderer/src/components/PassageDetail/mobile/MobileWorkflowSteps.tsx Outdated
@nghtctrl nghtctrl requested a review from gtryus May 19, 2026 19:44
Copy link
Copy Markdown
Contributor

@gtryus gtryus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also put some devin.ai comments into the code but here is one that doesn't fit in this module.

devin.ai reports this issue:
Cypress testing rule file references outdated SVG-based rendering
The .cursor/rules/cypress-testing-takeaways.mdc states: "WorkflowStepsMobile renders SVG stages (no visible text nodes). Assert on structure (svg, svg g)." The component no longer uses SVG — it now uses CSS clipPath on ButtonBase elements. The existing Cypress tests in MobileWorkflowSteps.cy.tsx correctly use data-cy selectors and don't rely on SVG structure, so they should still pass. However, the rule file is now stale and should be updated to reflect the new rendering approach (CSS clip-path parallelograms, passage dropdown). Similarly, the advice about dispatching a resize event after mount may no longer be needed since the width-driven step list was replaced with a flex/scroll layout.

Comment thread src/renderer/src/components/PassageDetail/mobile/MobileWorkflowSteps.tsx Outdated
@nghtctrl nghtctrl requested a review from gtryus May 20, 2026 19:32
@gtryus gtryus merged commit 0aa3fb3 into sillsdev:develop May 20, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants