Open
Conversation
Implements full-bleed behavior so source page box intent is preserved through passthrough and imposition flows. Key changes: - Keep crop marks as an outer-margin concern (MediaBox growth) without changing intended trim/bleed geometry. - Update NullLayoutMethod to preserve source TrimBox/BleedBox and only offset boxes when crop marks are enabled. - Update SideFoldBookletLayouter to map source TrimBox to panel trim and clip drawing to mapped bleed bounds. - Fix right-edge crop-mark coordinate placement bug in DrawCropMarks. - Expand README Full Bleed documentation and clarify client responsibility for fold-edge behavior.
It's not clear how/when this was useful to someone.
a608d5e to
a41f238
Compare
Member
Author
|
[GPT-5.3-Codex] Addressed both unresolved RTL review findings.
Validation run: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements full-bleed behavior so source page box intent is preserved through passthrough and imposition flows.
Key changes:
Keep crop marks as an outer-margin concern (MediaBox growth) without changing intended trim/bleed geometry.
Update NullLayoutMethod to preserve source TrimBox/BleedBox and only offset boxes when crop marks are enabled.
Update SideFoldBookletLayouter to map source TrimBox to panel trim and clip drawing to mapped bleed bounds.
Fix right-edge crop-mark coordinate placement bug in DrawCropMarks.
Expand README Full Bleed documentation and clarify client responsibility for fold-edge behavior.
This change is